Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

v2 refClass simplification#104

Merged
spacether merged 21 commits into2_0_0from
v2_refClass_simplification
Dec 19, 2022
Merged

v2 refClass simplification#104
spacether merged 21 commits into2_0_0from
v2_refClass_simplification

Conversation

@spacether
Copy link
Copy Markdown
Contributor

@spacether spacether commented Dec 19, 2022

  • only store the class name in refClass, this improves documentation readability where refclass is the name for ref model links
  • store the needed module in refModule (before this PR refModule was also stored in refClass for external import $refs)
    • refModule is null when the component is defined inline
  • adds correct import when first creating imports, deletes import fixing code

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title v2 ref class simplification v2 refClass simplification Dec 19, 2022
@spacether spacether added this to the 2.0.0 milestone Dec 19, 2022
@spacether spacether merged commit 780d5b2 into 2_0_0 Dec 19, 2022
@spacether spacether linked an issue Dec 20, 2022 that may be closed by this pull request
6 tasks
@spacether spacether deleted the v2_refClass_simplification branch January 12, 2023 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet